magento/magento2#18840: Invalid Unit Test Annotations.#19105
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Nov 9, 2018
swnsma:Backport-18840
Merged
magento/magento2#18840: Invalid Unit Test Annotations.#19105magento-engcom-team merged 1 commit intomagento:2.2-developfrom swnsma:Backport-18840
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
swnsma:Backport-18840
Conversation
magento-engcom-team
added
Partner: ISM eCompany
Contributor
|
Hi @swnsma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
- fixed invalid unit tests annotations that assert exception messages - backport to 2.2.
Contributor
Author
|
Author has been changed. |
orlangur
approved these changes
Nov 8, 2018
Contributor
|
Hi @orlangur, thank you for the review. |
Contributor
|
Hi @swnsma. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed invalid unit tests annotations that assert exception messages. With these changes, unit tests will assert exception messages correctly
Backport to 2.2.
Fix commit in accordance to 2.2 exception messages.
Fixed Issues (if relevant)
Manual testing scenarios (*)
No manual testing neede. All changes are covered with unit tests
Contribution checklist (*)